Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Fix #654

Merged
merged 10 commits into from
Mar 11, 2024
Merged

List Fix #654

merged 10 commits into from
Mar 11, 2024

Conversation

garrettmflynn
Copy link
Member

fix #649

@garrettmflynn garrettmflynn self-assigned this Mar 11, 2024
@bendichter
Copy link
Collaborator

Screen.Recording.2024-03-11.at.4.32.31.PM.mov

Two new problems:

  1. Any new added interface copies the renamed interface instead of starting with the default name.
  2. When you select and then deselect the name field, it adds "_1"

@garrettmflynn
Copy link
Member Author

Thank you for thoroughly testing these behaviors! I've fixed these behaviors by copying the item as it is added to the list—as it seems the reference used by the Search component was being modified in the above case.

@bendichter
Copy link
Collaborator

Screen.Recording.2024-03-11.at.4.46.45.PM.mov

OK, those problems are fixed, but now we have a new problem: If you add a 3rd interface of the same type without changing any names, the entire app freezes

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Mar 11, 2024

Missed an infinite loop caused by an improperly named variable (i when it should have been kI) 🫠

I'm updating my environment for the latest neuroconv version, but AFAIK this should fix this behavior.

@bendichter bendichter enabled auto-merge (squash) March 11, 2024 17:40
@bendichter bendichter merged commit 147a45e into main Mar 11, 2024
14 of 15 checks passed
@bendichter bendichter deleted the list-fix branch March 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renamed interfaces revert back to old name
3 participants