Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on failure #617

Closed
wants to merge 16 commits into from
Closed

Retry on failure #617

wants to merge 16 commits into from

Conversation

garrettmflynn
Copy link
Member

fix #613

This was suggested when merging #612

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn
Copy link
Member Author

That specific run has an issue because of No module named 'flask'. Seems like the create and activate environment step didn't run.

I've never noticed this become a problem before. Is there a reason this was excluded?

@CodyCBakerPhD
Copy link
Collaborator

Hmm... Could it be that the action isn't running in the same shell? (one in which the conda environment is not active?)

Adding a printout of the installed packages to be sure; the cache was restored in the logs I linked so you'd hope so

@garrettmflynn
Copy link
Member Author

Ah looks like that's the case. Just updated to the same shell.

Fingers crossed!

@garrettmflynn
Copy link
Member Author

Hmm all attempts here don't seem to help. According to the docs, this should default to bash on Mac and Linux—and otherwise it seems likely that it'd use the default set at the top of the workflow.

@CodyCBakerPhD
Copy link
Collaborator

Right, but specifying it as bash would be a fresh shell I believe, not the currently active conda environment; maybe add a conda activate nwb-guide as first step of the run command in the retry?

@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft February 21, 2024 17:27
@CodyCBakerPhD
Copy link
Collaborator

Tabling for now to see if we actually need this - #621 has been working well so far

@CodyCBakerPhD
Copy link
Collaborator

Yeah I don't think we actually need this any more

@CodyCBakerPhD CodyCBakerPhD deleted the retry-ci branch February 27, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Tests Fail Spontaneously
2 participants