Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appzi feedback form #606

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Add Appzi feedback form #606

merged 14 commits into from
Mar 14, 2024

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Feb 8, 2024

fix #604

@rly @CodyCBakerPhD You're welcome to create your own account, design the form how you'd like, then swap out the token

@garrettmflynn garrettmflynn self-assigned this Feb 8, 2024
@CodyCBakerPhD
Copy link
Collaborator

I leave this one to @rly since they pointed it out

@rly
Copy link
Collaborator

rly commented Feb 12, 2024

Thanks for the quick turnaround! I'm on vacation for the next two weeks and not able to test this, so I will review this in ~2 weeks if that's ok. (feel free to approve and merge now and I can open another issue/PR if I would like to change something.)

@garrettmflynn
Copy link
Member Author

Sounds good. Have a great vacation!

@CodyCBakerPhD
Copy link
Collaborator

Ping @rly

@CodyCBakerPhD
Copy link
Collaborator

Ping @rly

@rly
Copy link
Collaborator

rly commented Mar 11, 2024

This looks great! Where do the emails go?

@garrettmflynn
Copy link
Member Author

It should be going to my email and accumulated on the Appzi dashboard. Thought we'd want a shared workspace for the team—but I'm happy to take ownership of this for now.

I can also forward to Slack if that's of interest

src/renderer/index.html Outdated Show resolved Hide resolved
@rly
Copy link
Collaborator

rly commented Mar 12, 2024

The page reloads to the main landing page after I submit feedback. Do you experience that too? If so, do you happen to know why? I looked and couldn't figure out anything on our end that would be causing it, so perhaps it's on appzi's end, but that would be odd.

@garrettmflynn
Copy link
Member Author

Yes it's definitely on Appzi's end, either a call to window.location.reload or the equivalent default effect of the onsubmit callback for HTML forms.

Turns out it was more difficult than I'd imagined to block the forced reloading after Appzi submission while still allowing for QoL features like hot reloading and manual refreshing the page.

But it's working now! At this point, reloading is blocked when the Appzi form is open.

@CodyCBakerPhD CodyCBakerPhD requested a review from rly March 13, 2024 02:11
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) March 14, 2024 18:44
@rly
Copy link
Collaborator

rly commented Mar 14, 2024

Thanks for the fix @garrettmflynn ! Nice work. I can confirm that the page does not refresh after submitting feedback and hot reloading and manual refreshing still work.

@CodyCBakerPhD CodyCBakerPhD merged commit 85f04bb into main Mar 14, 2024
12 of 15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the appzi-feedback branch March 14, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Provide feedback" widget?
3 participants