-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appzi feedback form #606
Conversation
I leave this one to @rly since they pointed it out |
Thanks for the quick turnaround! I'm on vacation for the next two weeks and not able to test this, so I will review this in ~2 weeks if that's ok. (feel free to approve and merge now and I can open another issue/PR if I would like to change something.) |
Sounds good. Have a great vacation! |
Ping @rly |
Ping @rly |
This looks great! Where do the emails go? |
It should be going to my email and accumulated on the Appzi dashboard. Thought we'd want a shared workspace for the team—but I'm happy to take ownership of this for now. I can also forward to Slack if that's of interest |
Co-authored-by: Ryan Ly <[email protected]>
The page reloads to the main landing page after I submit feedback. Do you experience that too? If so, do you happen to know why? I looked and couldn't figure out anything on our end that would be causing it, so perhaps it's on appzi's end, but that would be odd. |
Yes it's definitely on Appzi's end, either a call to Turns out it was more difficult than I'd imagined to block the forced reloading after Appzi submission while still allowing for QoL features like hot reloading and manual refreshing the page. But it's working now! At this point, reloading is blocked when the Appzi form is open. |
Thanks for the fix @garrettmflynn ! Nice work. I can confirm that the page does not refresh after submitting feedback and hot reloading and manual refreshing still work. |
fix #604
@rly @CodyCBakerPhD You're welcome to create your own account, design the form how you'd like, then swap out the token