Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct installation links #599

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Collaborator

fix #595

Though, @garrettmflynn, is there a way you can remove the vX.Y.Z part from the file names? That's the only thing preventing us from using the latest tag and never having to update this to get it to work for latest releases (which I just know is going to slip up one day)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Feb 6, 2024
@garrettmflynn
Copy link
Member

Yep! We can add this to the build property of the package.json file: artifactName": "NWB-GUIDE-${arch}.${ext}". Apparently ${arch} and the leading dash will be removed if not present (e.g. for non-M1 Mac builds).

@CodyCBakerPhD
Copy link
Collaborator Author

Yep! We can add this to the build property of the package.json file: artifactName": "NWB-GUIDE-${arch}.${ext}". Apparently ${arch} and the leading dash will be removed if not present (e.g. for non-M1 Mac builds).

Coolio; we'll confirm that once next release is cut and update docs to match at that point and it should be taken care of automatically thereafter

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) February 6, 2024 19:36
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
@CodyCBakerPhD CodyCBakerPhD requested a review from rly February 7, 2024 00:11
@CodyCBakerPhD CodyCBakerPhD merged commit e938e22 into main Feb 7, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the direct_installation_links branch February 7, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put direct links to installation files in docs
4 participants