Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time alignment visualization #566

Merged
merged 14 commits into from
Jan 24, 2024
Merged

Time alignment visualization #566

merged 14 commits into from
Jan 24, 2024

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Jan 17, 2024

This PR adds a basic time alignment visualization similar to Neurosift. This can be toggled per-session on the Source Data page.

Screenshot 2024-01-17 at 10 39 16 AM

@garrettmflynn garrettmflynn self-assigned this Jan 17, 2024
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jan 17, 2024
@CodyCBakerPhD
Copy link
Collaborator

I get

Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at InstanceManager.onClick (GuidedSourceData.js:259:46)

on my end when I press the button

@garrettmflynn
Copy link
Member Author

Hmm this is working just fine for me. What data are you using?

@CodyCBakerPhD
Copy link
Collaborator

Still getting it; perhaps platform dependent?

It's just the standard tutorial

@garrettmflynn
Copy link
Member Author

Ah sure. I'll give it a go on my PC

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review January 24, 2024 17:33
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 24, 2024 17:33
@CodyCBakerPhD CodyCBakerPhD merged commit 7d60664 into main Jan 24, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the time-alignment branch January 24, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants