Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to generate pipelines from YAML files #563

Merged
merged 11 commits into from
Jan 23, 2024

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Jan 16, 2024

This PR allows for users to generate pipelines from a YAML file on the Settings page. Currently, enough metadata is pre-filled to simply click through the conversion without any interactions.

This is the first step to fix #511, where we can expand the test YAML file (guide_testing_suite.yml) to account for all interfaces.

Since receiving the test YAML file from @CodyCBakerPhD, I've removed the base_data_path property to improve the shareability of the file itself and fixed the PhySortingInterface folder path to target the correct subdirectory.

@garrettmflynn garrettmflynn self-assigned this Jan 16, 2024
@garrettmflynn
Copy link
Member Author

Likely we'll want to improve the user workflow here before merging into main.

@CodyCBakerPhD Let me know what you think is best, though this should be fully functional.

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn This particular feature is not intended to be the generic 'import from YAML' to be exposed to users; that feature would use the NeuroConv specific YAML structure (different from what I shared), and is largely dependent on the custom backend feature to be useful (and possibly other aspects, too) hence why it's not even on the current release roadmap

This particular feature was only supposed to result in a single button on the settings page for developers to point to their local copy of the GIN repos and auto-generate all pre-established pipelines defined in that YAML file (which will grow over time; each entry essentially being a test case)

@garrettmflynn
Copy link
Member Author

Got it. Constrained the behavior to load the provided file rather than allow the selection of a custom YAML file.

@CodyCBakerPhD
Copy link
Collaborator

  1. Are the generated pipelines working on your end? @garrettmflynn

  2. Minor, but would it be possible to visually join the button for genreation with the folder path selector to indicate they are related?

image

Perhaps under a 'Developer' testing header like the 'DANDI' one

@garrettmflynn
Copy link
Member Author

Are the generated pipelines working on your end? @garrettmflynn

Ah I see. Phy always was, but the SpikeGLX single-probe example had the wrong interface specified (should be SpikeGLXRecordingInterface not SpikeGLXDataInterface).

@garrettmflynn
Copy link
Member Author

Minor, but would it be possible to visually join the button for genreation with the folder path selector to indicate they are related?

Updated with this new grouping!

@CodyCBakerPhD
Copy link
Collaborator

Delightful

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 23, 2024 16:09
@CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD merged commit a3924b2 into main Jan 23, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the pipeline-generation branch January 23, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a conversion pipeline for each interface
2 participants