Update PyInstaller to 6.3 to fix missing imports in packaging #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rly
changed the title
Test using latest PyInstaller
|
@rly CI is passing now! Let me know when you're done cleaning up anything and ready for review Thanks for tackling this so quickly |
rly
changed the title
|
This PR now updates PyInstaller from 5.13.0 to the latest version, 6.3.0. This version includes a few breaking changes: https://pyinstaller.org/en/stable/CHANGES.html#id9 . I don't see anything obvious that would affect GUIDE. @CodyCBakerPhD @garrettmflynn please review these changes to PyInstaller to make sure nothing might break because of them. |
|
I also removed testing of the PyFlask build and distributable on ubuntu and removed that as a required test for merging PRs. |
CodyCBakerPhD
approved these changes
Jan 9, 2024
|
Thanks a bunch @rly ! |
This was referenced Jan 9, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #559, closes #556, closes #558, closes #560