Redesign Home Interaction #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Attempting to run a fresh tutorial pipeline on this PR results in my backend server crashing and restarting before it can even launch the pipeline; do I need to do something special when testing this branch? |
for more information, see https://pre-commit.ci
|
Changing the conversion page path messed up the progress |
CodyCBakerPhD
approved these changes
Jan 10, 2024
|
Love the consistency of the new workflow names! All works for me |
|
Storybook has some problems that start on the first couple of pipeline pages though |
|
Good catch! Similar issue, just fixed |
CodyCBakerPhD
approved these changes
Jan 10, 2024
Most still seem to be empty: https://www.chromatic.com/test?appId=640a4d93e34604f275368983&id=659f074e4699c6ad0c249ece |
Co-authored-by: Cody Baker <[email protected]>
|
Got it. That one had an inconsistent format for the updated line so it was missed on my first pass. Thanks! |
CodyCBakerPhD
approved these changes
Jan 11, 2024
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements recommendations made by @oruebel (in user test) and @rly (#531) to improve the user experience of interacting with the GUIDE home screen.
In particular, it swaps the original home screen with the Conversions page so that users can quickly engage with the main feature of the GUIDE: designing conversion pipelines.