Remove abbreviations #551
Merged
Remove abbreviations #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Backend tests are failing here |
| @@ -186,8 +186,8 @@ export class InstanceManager extends LitElement { | |||
| const input = this.shadowRoot.querySelector("#new-info input"); | |||
| input.focus(); | |||
|
|
|||
| const mousePress = (e) => { | |||
| if (!e.composedPath().includes(newInfoDiv)) { | |||
| const mousePress = (mousePressEvent) => { | |||
There was a problem hiding this comment.
What would you think about 'clickEvent' here?
Some implicit bias from neurodata experience led to a first reading as 'mouse (species) lever press', which are a type of common LabeledEvent
There was a problem hiding this comment.
Switching to pointerEvent since that's also a type of event in JS.
|
Some minor comments scattered across; otherwise looks good. Will give thorough hands on test after those are addressed so ensure nothing is unintentionally broken, otherwise will be good to go Thanks for taking the time to do this |
CodyCBakerPhD
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes abbreviations introduced on the
mainbranch that don't provide enough clarity for developers without significant JavaScript experience.There were all that I could find on a first pass. If additional abbreviations are identified or found to not be replaced here, we should make them explicit moving forward.