-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ephys Metadata #542
Ephys Metadata #542
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@rly Just FYI tested this today and it looks like there's a blocker to convert the Ecephys metadata. In addition, the relevant NeuroConv branch doesn't support OpenEphys yet |
So, IDK. The more I think about this the more I think it might be best to just do a custom GUIDE-side operation on each recording interface similar to how the ophys metadata breaks up different planes. NeuroConv has a low-code method of attaching properties and doesn't really think of them as tables until they are in the NWB file, so trying to redesign that approach is going to be fairly difficult (especially with schematic validation since this isn't counted as 'metadata') Probably best to do on a separate/fresh PR that runs on |
As far as the table validation goes, that would then give us total control over the structure to enforce on the table, largely inferred from the |
@CodyCBakerPhD Would you mind reiterating the conclusions we reached in today's meeting so I can push forward with a new PR confidently? |
@garrettmflynn separate hands on table for each recording interface; then a static non-interactive table that combines all of them to represent the way the actual NWB electrodes table will appear Although, I think the neurosift preview after the metadata page should effectively handle that part; if that's OK with @rly then we can just have the individual tables exposed on the file metadata page and defer the 'unification' to the NeuroConv write tools + neurosift rendering on that small output |
The tables will also need to support copy/pasting and the classic 'drag to copy/paste a repeated value' to be really usable if they don't do that already |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
replaced by #586 |
This PR re-enables Ephys metadata, integrating the changes to Ophys metadata (#505) and the last several months of updates.
To run this, make sure your environment is using the correct NeuroConv dev branch (catalystneuro/neuroconv#447), which exposes the
data_type
property that corresponds to the expected return type of the table properties. Otherwise, all table properties will default to string types.