Make default upload parallel params 1 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For this to truly take effect, we'd still want to (1) change the default on the Python end, as well as (2) stop populating the actual value of the form to the maximum value when the CPU information is returned from the server. I'll handle this quick |
|
Should be good to go. Also added a caution message so users understand the consequences of bumping this value. |
for more information, see https://pre-commit.ci
…thub.com/NeurodataWithoutBorders/nwb-guide into make_default_uploads_parallel_params_one
CodyCBakerPhD
commented
Dec 14, 2023
|
@garrettmflynn Small adjustment to displayed warning text, otherwise LGTM (but you need to approve since it's technically my PR lol) |
garrettmflynn
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alleviates problem of #540 as well as joblib seg faults when running the GUIDE with default values, but doesn't actually solve underlying problem (which is unclear what the cause even is at this point...)