Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crypto.createCipher with crypto.createCipheriv #532

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

garrettmflynn
Copy link
Member

Fixing this error found here: #522 (comment)

(node:3064) [DEP0106] DeprecationWarning: crypto.createDecipher is deprecated.
(Use `electron --trace-deprecation ...` to show where the warning was created)
[5744:1130/123830.054:ERROR:cert_issuer_source_aia.cc(36)] Error parsing cert retrieved from AIA (as DER):
ERROR: Couldn't read tbsCertificate as SEQUENCE
ERROR: Failed parsing Certificate

[5744:1130/123830.641:ERROR:cert_issuer_source_aia.cc(36)] Error parsing cert retrieved from AIA (as DER):
ERROR: Couldn't read tbsCertificate as SEQUENCE
ERROR: Failed parsing Certificate

Note that your global variables (e.g. API keys, output locations, etc.) will be wiped since we are not using the same algorithm to decipher those values from the encoded global JSON configuration.

@garrettmflynn garrettmflynn self-assigned this Dec 1, 2023
@garrettmflynn garrettmflynn marked this pull request as ready for review December 1, 2023 00:03
@CodyCBakerPhD
Copy link
Collaborator

Tests failing

Also, do we need to bump any lower bound versions on the crypto dependency?

@garrettmflynn
Copy link
Member Author

Fixing now. No need to bump, crypto is an inbuilt library in Node

@CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) December 8, 2023 19:17
@CodyCBakerPhD CodyCBakerPhD merged commit fcf2989 into main Dec 8, 2023
11 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the update-cipher branch December 8, 2023 19:28
This was referenced Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants