-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crypto.createCipher with crypto.createCipheriv #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Tests failing Also, do we need to bump any lower bound versions on the crypto dependency? |
Fixing now. No need to bump, |
CodyCBakerPhD
approved these changes
Dec 3, 2023
@garrettmflynn Stories failed on this PR: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/7078404813/job/19263835864 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Dec 8, 2023
This was referenced Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this error found here: #522 (comment)
Note that your global variables (e.g. API keys, output locations, etc.) will be wiped since we are not using the same algorithm to decipher those values from the encoded global JSON configuration.