Try to left align text of navbar links #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS This felt too small of an issue to create an issue ticket for, but let me know if that would be preferred. |
|
I also tried a CSS-based solution—but this is the best approach given the inconsistent widths of the icons themselves. When setting things to a uniform 25px outside of this PR, this is what it would look like: Not great balance between the original SODA icons and the new ones for the GUIDE. Could change them for new Material Icons, but that's a broader discussion. |
garrettmflynn
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text on the left nav bar is not left-aligned. This PR adjusts the margins of the SVGs to correct for that. I assume there is a reason the icons are different sizes. I think it does look better at these sizes, so I did not touch that.
Before:
After:
It's not pixel perfect if you zoom in - I'm not sure why - but it does look better to me now.