Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure conversions are synced #503

Merged
merged 9 commits into from
Nov 11, 2023
Merged

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Nov 9, 2023

This PR ensures that pages that are dependent on certain resolved features can trigger behaviors to create those features. Specifically, the Inspect and Neurosift pages now check for whether the stub files are up-to-date with the latest changes made in the GUIDE (e.g. if someone reviews the Inspector report, makes changes, and revisits without passing through the File Metadata page).

User Test Issue

  1. Not clear that you have to go back to File Metadata to regenerate the stub / conversion files…

@garrettmflynn garrettmflynn self-assigned this Nov 9, 2023
@CodyCBakerPhD
Copy link
Collaborator

CodyCBakerPhD commented Nov 10, 2023

@garrettmflynn Some conflicts here now (and tests failing)

@CodyCBakerPhD
Copy link
Collaborator

The left nav bar now reads as

Screenshot 2023-11-10 at 10 51 44 PM

which is confusing - is this an intended change?

@garrettmflynn
Copy link
Member Author

This was a noted consequence of #497. This should go away by reloading and starting a new conversion.

@CodyCBakerPhD
Copy link
Collaborator

Ah, right. Swapped devices since then and forgot to wipe all the ones on my new device

@CodyCBakerPhD
Copy link
Collaborator

OK this feels like a good interaction!

@CodyCBakerPhD CodyCBakerPhD merged commit 8b43a5f into main Nov 11, 2023
11 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the ensure-conversions-are-synced branch November 11, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants