Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit list order + values #492

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Edit list order + values #492

merged 7 commits into from
Nov 1, 2023

Conversation

garrettmflynn
Copy link
Member

This PR allows users to edit the order and values of list items generally (e.g. Experimenters, Video File Paths, etc.)

User Test Issues

  • No edit button for experimenters; couldn’t easily change order either

@garrettmflynn garrettmflynn self-assigned this Nov 1, 2023
@CodyCBakerPhD
Copy link
Collaborator

As discussed, backspacing all text from box selection should delete the entry instead of attempt to populate default

@garrettmflynn
Copy link
Member Author

Updated to delete the entry if the value is cleared. Also added a placeholder for where the item will move to if dragged

@CodyCBakerPhD
Copy link
Collaborator

Feels much better now, thanks

@CodyCBakerPhD CodyCBakerPhD merged commit b2b80df into main Nov 1, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the edit-list-order branch November 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants