-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Subject Table Validation Inside + Properly Copy-Paste Sessions (when empty) #491
Conversation
for more information, see https://pre-commit.ci
As discussed, attempt to fix the issue where I add a new subject but use an existing ID, have it not override all the previous work Perhaps automatically append some index/format to the new duplicated ID, similar to what happens when you copy+paste a file in the same directory on most OS? |
for more information, see https://pre-commit.ci
Fixed! I'm hesitant to add anything to the ID automatically, as this'll likely only happen for naive copy/paste operations—where I'd rather let the user know they need to input their own unique value. Additionally, this'll be managed internally for the next iteration of this (i.e. two tables). So will go away as a possible problem soon. |
@garrettmflynn Small conflict now |
Fixed! |
@garrettmflynn One question arose w.r.t. button placement in Chromatic (may have occurred in previous PR without me realizing until now) If unrelated to changes of this PR we can go ahead and merge as-is and follow up with a specific fix for that (or if intentional, let me know and we can discuss further) |
You're right, this is a mistake that was on main. I've pushed there directly—so it should be gone. |
@garrettmflynn Cool, just a small conflict here now |
for more information, see https://pre-commit.ci
This PR moves all of the subject table validation steps inside the Table itself—requiring that Subject ID and Sessions are both provided to validate.
A fix for session copy-pasting is also provided, though this only works when the Subject cell is empty (because of an internal HOT issue #153)