-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control DANDI Jobs and Threads #490
Conversation
@garrettmflynn Is there a way to constrain the values of the IntRangeSlider to not include zero? Also to include in the description something about how |
Not yet—but I will make a way. Users can also free-input any flat value, so I'll implement a way to automatically round those too. |
@garrettmflynn Yeah, that too - for setting maximum caps here is the Python snippet if you want to add a simple endpoint to grab that value from the system reliably from psutil import cpu_count
max_number_of_jobs = cpu_count(logical=False) |
Working on this now. Is there a similar way to bound threads? |
Just pushed the proper workflow for jobs. Threads currently have no maximum |
for more information, see https://pre-commit.ci
Yessir, number_of_threads = cpu_count(logical=True) / cpu_count(logical=False) (which is really threads per job, not the grand total - but that's what DANDI would want specified anyhow) |
Sweet updated. Should be ready for review now |
One minor update to a description and otherwise LGTM |
Co-authored-by: Cody Baker <[email protected]>
Awesome. Glad we're getting this in |
@garrettmflynn One question on the effect of the new chromatic stories |
Working locally now on Storybook |
for more information, see https://pre-commit.ci
This PR allows users to control the number of jobs and threads when uploading to DANDI on the GUIDE.
May fix the segmentation fault issue we discovered during alpha tests.