Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject Table Updates #485

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Subject Table Updates #485

merged 8 commits into from
Oct 31, 2023

Conversation

garrettmflynn
Copy link
Member

This PR improves the subject table so that it aligns with the behavior of the rest of the GUIDE's form systems:

  1. Requirements are shown using asterisks
  2. Headers are sorted by priority and alphabetically
  3. Old rows are removed properly
  4. Throw an error when a Session ID is not provided (fix)

User Testing Issues

  • Description property is not earlier in the table
  • Does not have a way to NOT specify time of day for DOB. This currently defaults to the current time…not midnight [manual typing was used to override]
  • Not clear what is required vs. optional in the subject table

@garrettmflynn garrettmflynn self-assigned this Oct 30, 2023
@CodyCBakerPhD
Copy link
Collaborator

LGTM

@CodyCBakerPhD CodyCBakerPhD merged commit 1ea2f56 into main Oct 31, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the update-subject-table branch October 31, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants