Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DANDI API Workflow #480

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Update DANDI API Workflow #480

merged 6 commits into from
Oct 30, 2023

Conversation

garrettmflynn
Copy link
Member

This PR updates the DANDI API key workflow in alignment with the recent alpha tests. Instead of redirecting to the settings page, a modal provides the specific API key for the user to fill out without leaving the page. This input is validated and updates the global metadata.

An additional check for whether the API key provided is actually authorized has also been added, ensuring users will provide an API key that works—and which will fail and prompt them if it doesn't.

Alpha Test Issues

  • No links to DANDI
  • Hard to get back to your conversion quickly
  • DANDI API key validation is not informative
  • Should be extremely clear that you actually have to create a dandiset (staging for now) for the conversion to upload there

@garrettmflynn garrettmflynn self-assigned this Oct 27, 2023
@CodyCBakerPhD
Copy link
Collaborator

Yes, very cool! Glad it was that easy

@CodyCBakerPhD CodyCBakerPhD merged commit 5b58f1a into main Oct 30, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the update-dandi-api-workflow branch October 30, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants