Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data flow #477

Merged
merged 16 commits into from
Oct 31, 2023
Merged

Update data flow #477

merged 16 commits into from
Oct 31, 2023

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Oct 26, 2023

This PR ensures proper data flow in the following conditions:

  1. Invalid inputs into Global Metadata fields
  2. Exiting and starting a new conversion after visiting the Locata Data page
  3. Removing a subject / session / interface after filling out information on the Source Data (and later) page.
  4. Wanting to use path expansion for one interface but not another
  5. Deciding to re-run path expansion while keeping data for subjects / sessions that aren't found the second time around

Specifically for (5), I've added a new input to the top of the Locate Data page that allows users to decide to keep / clear data that already exists.

Alpha Test Issues

  1. After Locate Data, extra interface source data remains in the data structure.

@garrettmflynn garrettmflynn self-assigned this Oct 26, 2023
@garrettmflynn garrettmflynn marked this pull request as ready for review October 27, 2023 18:00
@garrettmflynn
Copy link
Member Author

@CodyCBakerPhD Just tested this PR fully and added a few more points to the description above.

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Any idea why tests are failing?

@garrettmflynn
Copy link
Member Author

Yeah just was missing a variable after the refactor. Fixed!

@CodyCBakerPhD CodyCBakerPhD merged commit 14feb6d into main Oct 31, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-data-flow branch October 31, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants