-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selection of converters with SpikeGLXConverter Support #467
Conversation
for more information, see https://pre-commit.ci
Fixed this issue. Was just because my testing dataset—specifically the NIDQ file for the SpikeGLX test—wasn't properly resolved |
Overall looks great as a first introduction I like the organization within the search tab too Two minor comments, both of which can be left as future To-Do items (raise as separate issues if you desire) i) I like the little hover info in general, but note that a lot of these descriptions were tailored to sphinx. Any idea on how to better parse the inter-sphinx links like seen below? Just looks kind of awkward - and a lot of those are programmatic ii) The section headers could be a little more identifiable - larger maybe? Gray background? Different format? The fact that it's not clickable is a decent indicator though |
For (i), what would the ideal returned string be for an entry with these inter-sphinx links? Maybe for I'll get a quick fix ready for (ii) otherwise. |
For (i) the E.g., We don't need to go to that level of course; I would just use the name stripped after the |
fix #174
This PR adds sub-converters to the options available to the user.
There's currently a blocking error when attempting to instantiate the custom converter on the GUIDE backend: