Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neuralynx Recording #445

Merged
merged 10 commits into from
Oct 17, 2023
Merged

Add Neuralynx Recording #445

merged 10 commits into from
Oct 17, 2023

Conversation

garrettmflynn
Copy link
Member

This PR adds NeuralynxRecordingInterface, which was successful on the test data for Cheetah_v5.6.3.

@garrettmflynn garrettmflynn self-assigned this Oct 16, 2023
@garrettmflynn garrettmflynn changed the base branch from main to fix_config_loading October 16, 2023 20:21
Base automatically changed from fix_config_loading to main October 16, 2023 20:30
@CodyCBakerPhD
Copy link
Collaborator

Bizarre issue for me; when I follow the Folder selector that appears on the source data page, and select my folder of neuralynx data, I get

Uncaught (in promise) Error: <h5 style="margin-bottom: 0;">Incorrect filesystem object</h5> <small>Please provide a <b>directory</b> instead.</small>
    at #onThrow (FileSystemSelector.js:104:15)
    at #checkType (FileSystemSelector.js:131:26)
    at Array.forEach (<anonymous>)
    at #handleFiles (FileSystemSelector.js:137:53)
    at FilesystemSelector.selectFormat (FileSystemSelector.js:165:30)

@garrettmflynn garrettmflynn added the interface Add support for a specific NeuroConv interface / converter label Oct 16, 2023
@garrettmflynn
Copy link
Member Author

Oh right, I was using a heuristic to detect files vs. directories that might be passed using drag-and-drop (i.e. not controlled natively)—but that was just checking whether there are . characters in the path.

Added a direct check when Electron (Node) libraries are accessible.

@CodyCBakerPhD
Copy link
Collaborator

Note to self: electrode table is a bit messy, need to clean up all those excessive/uninformative columns

Otherwise looks good!

@CodyCBakerPhD CodyCBakerPhD merged commit 6395832 into main Oct 17, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the neuralynx2 branch October 17, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface Add support for a specific NeuroConv interface / converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants