Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Test #3 (Alessio) Updates #438

Merged
merged 12 commits into from
Oct 16, 2023
Merged

User Test #3 (Alessio) Updates #438

merged 12 commits into from
Oct 16, 2023

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Oct 11, 2023

Includes several other cosmetic fixes that were relevant to proper rendering / navigation of the pages and how we communicate these things to the user.

fix #429

  • ”guided mode” url did not go to the correct location
  • Tried updating the base folder in the Locate Data page. Dynamic prediction of path expander did not update correctly w.r.t. Changes to base directory
  • “2 errors on this table” thrown twice when Age is wrong
  • No feedback on hitting save button on metadata page
  • Neurosift unable to connect to stub files because the preview folder doesn’t appear to be created at the home level
  • Tried to click the top ‘-’ buttons where one is colored green and other is white (counter indicator through steps of subworkflow)
  • Unsure what cleanup button meant on DANDI upload page
  • Conversions page says “Continue Converting” instead of “Edit pipeline”
  • The severity of warnings vs. errors is never explicitly addressed.
  • Search bar is not sticky to the top of the modal—so you can’t search if you’re deep in the list
  • Bottom two buttons on first page had terrible overlap with the three panels behind
  • Not clear what the top-level buttons do on the Tutorial page
  • It’s unclear that you don’t need the Main API key at the same time as the staging API (for the tutorial)
  • cannot see the whole error for generating dataset because it is clipped

@garrettmflynn garrettmflynn self-assigned this Oct 11, 2023
@CodyCBakerPhD
Copy link
Collaborator

Clicking 'Generate Data Structure' on this page

image

leads to

GuidedSubjects.js:42 Uncaught (in promise) TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at GuidedSubjectsPage.beforeTransition (GuidedSubjects.js:42:35)
    at Main.to (Page.js:64:14)
    at GuidedFooter.to (GuidedFooter.js:51:54)
    at GuidedFooter.onNext [as __onNext] (GuidedFooter.js:32:29)
    at EventPart.handleEvent (lit-html.ts:2018:29)

@CodyCBakerPhD
Copy link
Collaborator

CodyCBakerPhD commented Oct 14, 2023

Also, I'm still able to insert some initial values to the age field, and if they are invalid, then I remove them, they stay invalid

image

Edit: After navigating to this page, I am also unable to navigate anywhere else, even after forcing refresh

@garrettmflynn
Copy link
Member Author

Fixed those validation issues!

@CodyCBakerPhD
Copy link
Collaborator

Tried to click the top ‘-’ buttons where one is colored green and other is white (counter indicator through steps of subworkflow)

Are these supposed to be clickable now?

@garrettmflynn
Copy link
Member Author

IMO the users should use the navigation sidebar to handle page jumps. So I tried to make clearer that these are not clickable by removing the hover pointer (i.e. the cursor no longer reacts when it is placed over the '-').

Do you think we should allow users to click these other elements ('-', section flow headers, etc.)?

@CodyCBakerPhD
Copy link
Collaborator

It’s unclear that you don’t need the Main API key at the same time as the staging API (for the tutorial)

Looks like this is only being countered via documentation, but I'm not sure the way it is now completely resolves all confusion about which API key is needed

But it's a lower priority thing so maybe it can go to the backburner

Do you think we should allow users to click these other elements ('-', section flow headers, etc.)?

I do - people had the intuition that it was clickable even without the hover, as their eyes were more immediately drawn to that than to the side bar

@CodyCBakerPhD
Copy link
Collaborator

OK went through everything and this is definitely a big improvement

The only way to test some of these things (that were specific to Alessio) would be to do a follow up with him

If you want to move clickability of pill boxes to a separate PR that would be fine by me, just let me know

@garrettmflynn
Copy link
Member Author

Alright, the capsules are now clickable.

Looks like this is only being countered via documentation, but I'm not sure the way it is now completely resolves all confusion about which API key is needed

Do you have any suggestions for a better fix? I can implement something else quickly—otherwise I think it's fine to put this into a separate issue.

@CodyCBakerPhD
Copy link
Collaborator

Do you have any suggestions for a better fix? I can implement something else quickly—otherwise I think it's fine to put this into a separate issue.

Alas I do not, otherwise I'd mention it 🤔 Fine to raise as a separate issue if you can make that

@CodyCBakerPhD
Copy link
Collaborator

Can confirm capsules are reactive and... slightly pleasurable to be able to click after all this time. Especially on that first batch of 5 pages, I can see why people intuited that as a form of page navigation

@CodyCBakerPhD CodyCBakerPhD merged commit 67f5993 into main Oct 16, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the retreat-user-test-3 branch October 16, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Staging key should not show up as required (or red banner) if not specified in settings
2 participants