-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Test #3 (Alessio) Updates #438
Conversation
Clicking 'Generate Data Structure' on this page leads to GuidedSubjects.js:42 Uncaught (in promise) TypeError: Cannot convert undefined or null to object
at Function.keys (<anonymous>)
at GuidedSubjectsPage.beforeTransition (GuidedSubjects.js:42:35)
at Main.to (Page.js:64:14)
at GuidedFooter.to (GuidedFooter.js:51:54)
at GuidedFooter.onNext [as __onNext] (GuidedFooter.js:32:29)
at EventPart.handleEvent (lit-html.ts:2018:29) |
for more information, see https://pre-commit.ci
Fixed those validation issues! |
…houtBorders/nwb-guide into retreat-user-test-3
for more information, see https://pre-commit.ci
Are these supposed to be clickable now? |
IMO the users should use the navigation sidebar to handle page jumps. So I tried to make clearer that these are not clickable by removing the hover pointer (i.e. the cursor no longer reacts when it is placed over the '-'). Do you think we should allow users to click these other elements ('-', section flow headers, etc.)? |
Looks like this is only being countered via documentation, but I'm not sure the way it is now completely resolves all confusion about which API key is needed But it's a lower priority thing so maybe it can go to the backburner
I do - people had the intuition that it was clickable even without the hover, as their eyes were more immediately drawn to that than to the side bar |
OK went through everything and this is definitely a big improvement The only way to test some of these things (that were specific to Alessio) would be to do a follow up with him If you want to move clickability of pill boxes to a separate PR that would be fine by me, just let me know |
for more information, see https://pre-commit.ci
Alright, the capsules are now clickable.
Do you have any suggestions for a better fix? I can implement something else quickly—otherwise I think it's fine to put this into a separate issue. |
Alas I do not, otherwise I'd mention it 🤔 Fine to raise as a separate issue if you can make that |
Can confirm capsules are reactive and... slightly pleasurable to be able to click after all this time. Especially on that first batch of 5 pages, I can see why people intuited that as a form of page navigation |
Includes several other cosmetic fixes that were relevant to proper rendering / navigation of the pages and how we communicate these things to the user.
fix #429