Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try new docs theme #409

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Try new docs theme #409

merged 8 commits into from
Oct 5, 2023

Conversation

CodyCBakerPhD
Copy link
Collaborator

Hoping this is all it takes to use the more modern docs theme

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 29, 2023
@CodyCBakerPhD
Copy link
Collaborator Author

@garrettmflynn could you try stretching the window containing the table on this PR? The new theme should allow it to look better

@CodyCBakerPhD
Copy link
Collaborator Author

Both vertically and horizontally might be worth trying, this new theme leaves a lot of free space

@garrettmflynn
Copy link
Member

Width restriction is built into the theme—but I did add about 20vh more height to the table: https://nwb-guide.readthedocs.io/en/try_new_docs_theme/format_support.html (may still be building)

Setting width anything other than 100% results in a smaller table OR hidden overflow that cannot be scrolled.

@CodyCBakerPhD
Copy link
Collaborator Author

Dang 🤔 I guess we just have to shrink the table itself a little bit then? catalystneuro/format-support-table#9

Even zooming out on the new theme page doesn't quite fit the whole thing vertically

Not a huge deal at the end of the day, just feels like it ought to be fixable

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review October 5, 2023 08:19
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@CodyCBakerPhD CodyCBakerPhD merged commit 38284f0 into main Oct 5, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the try_new_docs_theme branch October 5, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants