Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Path Expansion Page #390

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Sep 22, 2023

fix #381

  • A complete example is contained in the information toggle previously defined with an external link
  • The information toggle is automatically open when the user firsts visits the page (i.e. if Yes / No has not been selected yet)
  • A box shows beneath each format_string_path input with the current source file matches, while the full metadata is printed to the console

In attempting to implement all the suggestions, I decided it wouldn't be worthwhile to approach (3) and parts of (4) without further discussion.

  • Auto-populating the format_string_path input is too unpredictable what the user might want (e.g. for the tutorial pipeline, I don't have enough knowledge to select a Phy folder or a SpikeGLX-related file if both exist at the lowest level of the base_directory)
  • Listing out all the entities in the base directory will almost always be a lot of files / folders—too many to show nicely in a naive way.

Are there alternative approaches that y'all would suggest or something that I haven't implemented here that you'd like to see still?

@garrettmflynn
Copy link
Member Author

Based on our discussion today, we can wait for an implementation of (3) based on #397. This PR should be good for review.

@garrettmflynn garrettmflynn marked this pull request as ready for review September 28, 2023 22:13
@CodyCBakerPhD
Copy link
Collaborator

I like. Will get @bendichter's feedback on this during that one on one alpha test

@CodyCBakerPhD CodyCBakerPhD merged commit 754f753 into main Oct 2, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the updated-path-expansion-page branch October 2, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Path Expansion Page for Improved Usability
2 participants