Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upload BeforeSave Callback #359

Merged
merged 11 commits into from
Sep 14, 2023
Merged

Fix Upload BeforeSave Callback #359

merged 11 commits into from
Sep 14, 2023

Conversation

garrettmflynn
Copy link
Member

fix #357

@CodyCBakerPhD
Copy link
Collaborator

That resolved that issue, now on to

ncaught (in promise) Error: Request to upload/folder failed: upload_folder_to_dandi() got an unexpected keyword argument 'project'
    at run (utils.js:35:33)
    at async GuidedUploadPage.uploadToDandi (UploadsPage.js:32:12)
    at async GuidedFooter.onNext [as __onNext] (GuidedUpload.js?t=1694567791220:50:29)

@garrettmflynn
Copy link
Member Author

I was seeing this before if I didn't start a new conversion. Can you try that?

@CodyCBakerPhD
Copy link
Collaborator

I was seeing this before if I didn't start a new conversion. Can you try that?

Yep, confirmed with an entirely newly generated tutorial pipeline

Will try a non-tutorial one now

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn If it's any help at giving more context, I always seem to get this screen even if it is definitely the first time I've ever tried uploading this session

image

@CodyCBakerPhD
Copy link
Collaborator

And yeah, same issue again in a custom pipeline once I press that 'continue with reupload' button

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Sep 13, 2023 via email

@garrettmflynn
Copy link
Member Author

Alright this is fixed and merged with main

@CodyCBakerPhD
Copy link
Collaborator

Tested both guided mode page and stand alone page - both worked great!

@CodyCBakerPhD CodyCBakerPhD merged commit 752a093 into main Sep 14, 2023
4 of 7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-upload-beforesave branch September 14, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DANDI Upload via final guided mode page
2 participants