Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M1 Mac environment] Try neuroconv specific debug #358

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

CodyCBakerPhD
Copy link
Collaborator

Trying a suggestion on your PR @rly

@CodyCBakerPhD
Copy link
Collaborator Author

NeuroConv branch/PR: catalystneuro/neuroconv#563

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 12, 2023
@CodyCBakerPhD CodyCBakerPhD requested a review from rly September 12, 2023 16:30
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 12, 2023 16:58
@CodyCBakerPhD
Copy link
Collaborator Author

@rly I confirmed on my M1 I no longer need to do the uninstallation of sonpy step with this fix to NeuroConv

I'll update the branch pin once it's merged to main on NeuroConv

@CodyCBakerPhD
Copy link
Collaborator Author

I'll update the branch pin once it's merged to main on NeuroConv

Upstream was merged, so updated here. main of NeuroConv should no longer install sonpy at all on M1

@CodyCBakerPhD CodyCBakerPhD merged commit 82451bc into debug_mac_dist Sep 13, 2023
6 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the more_debugs_m1 branch September 13, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants