Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Inspector Results #326

Merged
merged 59 commits into from
Aug 25, 2023
Merged

Preview Inspector Results #326

merged 59 commits into from
Aug 25, 2023

Conversation

garrettmflynn
Copy link
Member

fix #186

This PR runs the appropriate functions on the backend to provide NWB Inspector results. Additionally, new components have been derived from existing ones to support the visualization of these results.

Note: Since we're back to requesting more than one piece of information from the conversion results, most of the frontend changes from #324 and #316 will become obsolete.

@garrettmflynn garrettmflynn self-assigned this Aug 23, 2023
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Aug 23, 2023
Merged
@garrettmflynn garrettmflynn mentioned this pull request Aug 23, 2023
Closed
garrettmflynn and others added 13 commits August 23, 2023 14:59
@garrettmflynn
Fix results page
566e7e0
@garrettmflynn
Merge branch 'preview-inspector-results' of https://github.com/Neurod…
8df6a46 
…ataWithoutBorders/nwb-guide into preview-inspector-results
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
385ac10 
for more information, see https://pre-commit.ci
@garrettmflynn
Update popup title
ab5c97c
@garrettmflynn
Merge branch 'main' into preview-inspector-results
b6bb7ba
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1592ca8 
for more information, see https://pre-commit.ci
@garrettmflynn
Merge branch 'main' into preview-inspector-results
27e7de0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6814cad 
for more information, see https://pre-commit.ci
@garrettmflynn
Merge branch 'main' into preview-inspector-results
d0f10e5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f499150 
for more information, see https://pre-commit.ci
@garrettmflynn
Create instance renders dynamically
55641ec
@garrettmflynn
Merge branch 'preview-inspector-results' of https://github.com/Neurod…
53b87af 
…ataWithoutBorders/nwb-guide into preview-inspector-results
@garrettmflynn
Show loader for iframe
bbb1ceb
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Aug 25, 2023
Closed
@CodyCBakerPhD
Copy link
Collaborator

Tried npm ci as well as removing existing build, neither fixed the display issue of the by-session report

Full console stack, if it helps

index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:15] "POST /neuroconv/convert HTTP/1.1" 200 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:15] "OPTIONS /neuroconv/inspect_folder HTTP/1.1" 200 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.
index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:16] "OPTIONS /stubs/NWB%20GUIDE%20Tutorial%20Data/sub-mouse1/sub-mouse1_ses-060623.nwb HTTP/1.1" 200 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
3index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:16] "GET /stubs/NWB%20GUIDE%20Tutorial%20Data/sub-mouse1/sub-mouse1_ses-060623.nwb HTTP/1.1" 200 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index-32bccb0f.js:1321 Requesting meta for http://127.0.0.1:4242/stubs/NWB%20GUIDE%20Tutorial%20Data\sub-mouse1\sub-mouse1_ses-060623.nwb
index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:16] "GET /stubs/NWB%20GUIDE%20Tutorial%20Data/sub-mouse1/sub-mouse1_ses-060623.nwb HTTP/1.1" 206 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index-32bccb0f.js:1321 Rtcshare protocol version 0.1.0
4index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:16] "GET /stubs/NWB%20GUIDE%20Tutorial%20Data/sub-mouse1/sub-mouse1_ses-060623.nwb HTTP/1.1" 206 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
RemoteH5Worker-26de57b1.js:3 HDF5-DIAG: Error detected in HDF5 (1.12.2) thread 0:
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func873 @ 0098540e:0x8cff9
$func164 @ 0098540e:0x1b1bb
$func2087 @ 0098540e:0x147b10
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func970 @ 0098540e:0x9b3cc
$func681 @ 0098540e:0x6fdf6
$func2064 @ 0098540e:0x140703
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3   #000: /__w/libhdf5-wasm/libhdf5-wasm/wasm_build/1_12_2/_deps/hdf5-src/src/H5O.c line 487 in H5Oexists_by_name(): name parameter cannot be an empty string
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147bbf
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func970 @ 0098540e:0x9b3cc
$func681 @ 0098540e:0x6fdf6
$func2064 @ 0098540e:0x140703
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3     major: Invalid arguments to routine
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147be5
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func970 @ 0098540e:0x9b3cc
$func681 @ 0098540e:0x6fdf6
$func2064 @ 0098540e:0x140703
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3     minor: Bad value
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147c08
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func970 @ 0098540e:0x9b3cc
$func681 @ 0098540e:0x6fdf6
$func2064 @ 0098540e:0x140703
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3 HDF5-DIAG: Error detected in HDF5 (1.12.2) thread 0:
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func873 @ 0098540e:0x8cff9
$func164 @ 0098540e:0x1b1bb
$func2087 @ 0098540e:0x147b10
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func1493 @ 0098540e:0xf2036
$func2064 @ 0098540e:0x140725
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3   #000: /__w/libhdf5-wasm/libhdf5-wasm/wasm_build/1_12_2/_deps/hdf5-src/src/H5Gdeprec.c line 930 in H5Gget_objinfo(): no name specified
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147bbf
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func1493 @ 0098540e:0xf2036
$func2064 @ 0098540e:0x140725
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3     major: Invalid arguments to routine
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147be5
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func1493 @ 0098540e:0xf2036
$func2064 @ 0098540e:0x140725
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
RemoteH5Worker-26de57b1.js:3     minor: Bad value
put_char @ RemoteH5Worker-26de57b1.js:3
write @ RemoteH5Worker-26de57b1.js:1
write @ RemoteH5Worker-26de57b1.js:3
iC @ RemoteH5Worker-26de57b1.js:21
aC @ RemoteH5Worker-26de57b1.js:21
$func1994 @ 0098540e:0x1389a0
$func868 @ 0098540e:0x8cd33
$func1213 @ 0098540e:0xcb967
$func73 @ 0098540e:0x4be0
$func2087 @ 0098540e:0x147c08
$func1328 @ 0098540e:0xd6b77
$func1329 @ 0098540e:0xd6c63
$func2093 @ 0098540e:0x14803f
$func79 @ 0098540e:0x5581
$func1493 @ 0098540e:0xf2036
$func2064 @ 0098540e:0x140725
$func1271 @ 0098540e:0xcfd31
get_type @ VM36:9
get_type @ RemoteH5Worker-26de57b1.js:22
get @ RemoteH5Worker-26de57b1.js:22
xC @ RemoteH5Worker-26de57b1.js:22
await in xC (async)
M @ RemoteH5Worker-26de57b1.js:22
self.onmessage @ RemoteH5Worker-26de57b1.js:22
index-32bccb0f.js:1228 Uncaught (in promise) Error: Group not found: <undefined>
    at Worker.o (index-32bccb0f.js:1228:18167)
o @ index-32bccb0f.js:1228
await in o (async)
(anonymous) @ index-32bccb0f.js:1081
qh @ index-32bccb0f.js:40
S7 @ index-32bccb0f.js:40
(anonymous) @ index-32bccb0f.js:40
v @ index-32bccb0f.js:25
C @ index-32bccb0f.js:25
index.js:29 [main-process]: Source data is valid!
Metadata is valid!
conversion_options is valid!
NWB file saved at C:\Users\Raven\NWB_GUIDE\stubs\NWB GUIDE Tutorial Data\sub-mouse1\sub-mouse1_ses-060623.nwb!
Source data is valid!
Metadata is valid!
conversion_options is valid!
NWB file saved at C:\Users\Raven\NWB_GUIDE\stubs\NWB GUIDE Tutorial Data\sub-mouse1\sub-mouse1_ses-070623.nwb!
Source data is valid!
Metadata is valid!
conversion_options is valid!
NWB file saved at C:\Users\Raven\NWB_GUIDE\stubs\NWB GUIDE Tutorial Data\sub-mouse2\sub-mouse2_ses-060623.nwb!
Source data is valid!
Metadata is valid!
conversion_options is valid!
NWB file saved at C:\Users\Raven\NWB_GUIDE\stubs\NWB GUIDE Tutorial Data\sub-mouse2\sub-mouse2_ses-070623.nwb!

index.js:29 [main-process]: 
Inspecting NWBFiles...: 0it [00:00, ?it/s]
(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index.js:29 [main-process]: 
                                          

Inspecting NWBFiles...: 0it [00:00, ?it/s]
(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index.js:29 [main-process]: 
                                          
(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69
index.js:29 [main-process]: 127.0.0.1 - - [24/Aug/2023 23:06:21] "POST /neuroconv/inspect_folder HTTP/1.1" 200 -

(anonymous) @ index.js:29
emit @ node:events:526
onMessage @ node:electron/js2c/renderer_init:69

garrettmflynn and others added 11 commits August 25, 2023 08:43
@garrettmflynn
Align conversion message with main
c805d03
@garrettmflynn
Update header for stub preview
6ce616a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4ceb940 
for more information, see https://pre-commit.ci
@garrettmflynn @CodyCBakerPhD
Update pyflask/apis/neuroconv.py
697ab70 
Co-authored-by: Cody Baker <[email protected]>
@garrettmflynn @CodyCBakerPhD
Apply suggestions from code review
d245ae9 
Co-authored-by: Cody Baker <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3e08b03 
for more information, see https://pre-commit.ci
@garrettmflynn
Remove inspector kwargs overrides from the frontend
b60df94
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e2dca4e 
for more information, see https://pre-commit.ci
@garrettmflynn
Update inspector test JSON
006c749
@garrettmflynn
Merge branch 'preview-inspector-results' of https://github.com/Neurod…
6d99588 
…ataWithoutBorders/nwb-guide into preview-inspector-results
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
053d69d 
for more information, see https://pre-commit.ci
@garrettmflynn
Copy link
Member Author

Tried npm ci as well as removing existing build, neither fixed the display issue of the by-session report

We should probably hop on a call to figure this out. Would sometime to day be convenient for you?

@CodyCBakerPhD
Copy link
Collaborator

As discussed, this is a fine first step but there are several improvements yet to be made to make the workflow more modular and informative about how to display aggregated problems as well as how to fix things within the context of the GUIDE

@CodyCBakerPhD CodyCBakerPhD merged commit 3a1acd9 into main Aug 25, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the preview-inspector-results branch August 25, 2023 18:41
@garrettmflynn garrettmflynn mentioned this pull request Aug 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyCBakerPhD CodyCBakerPhD CodyCBakerPhD approved these changes

Assignees

@garrettmflynn garrettmflynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Idea] Run NWB Inspector and print out report during preview
2 participants
@garrettmflynn @CodyCBakerPhD