-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and Deploy Windows #283
Conversation
Same issue as that reported in #256. Seems like it'll be restricted to Windows, maybe even just my environment. Otherwise the deployment commands should be correct:
After running |
I've tried uninstalling and reinstalling |
Do you run into that same issue when running from an installation of the release version? https://github.com/NeurodataWithoutBorders/nwb-guide/releases/tag/untagged-9f2a67352fcc3420eed5 |
Huh, when I adapt your Trying a rerelease from this branch now |
But does it start the Python server properly? The issue is generally that we can't get that script to run properly. This looks like the previous issues around finding the correct file path. Will see if we need to dig into that more. |
No distributable we currently have that I can test (Linux and Windows) runs the backend successfully due the scipy issue The front-end itself even started properly in this case, I just wanted to leave a record of the error window that popped up upon launching the app |
The CI shows the same behavior as our local devices, but does not return a zero exit code and so the GitHub workflow proceeds without catching the failure: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/5858252120/job/15881822817 I was going to insert a throw new Error("The distributable pyflask failed to run!"); below https://github.com/NeurodataWithoutBorders/nwb-guide/blob/fix_windows_deployment/tests/testPyinstallerExecutable.js#L34 - is that what you would recommend? |
Yeah that should work. |
The workflow is green: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/workflows/Build-and-deploy-win.yml
But when I install from the release: https://github.com/NeurodataWithoutBorders/nwb-guide/releases/tag/untagged-953a574ccfe5adc959bc
Everything goes well up until the connection to the back-end, which times out
My suggestion, since we all work on different devices, and since Mac is more touchy about signing issues than the other platforms, is that we focus on debugging the sister PR #284 for linux on the DANDI Hub (remote desktop), which is the common linux environment we all have access to