Skip to content

Commit

Permalink
Fix merge
Browse files Browse the repository at this point in the history
  • Loading branch information
garrettmflynn committed Jun 5, 2024
1 parent a9b7f37 commit df7fde0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
7 changes: 3 additions & 4 deletions src/electron/frontend/core/components/pages/Page.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export class Page extends LitElement {

const { close: closeProgressPopup } = swalOpts;


const fileConfiguration = [];

try {
Expand Down Expand Up @@ -245,9 +246,7 @@ export class Page extends LitElement {
this.notify(message, "error");
throw error;
})

.finally(() => closeProgressPopup());


results.forEach((info) => {
const { file } = info;
const fileName = file.split("/").pop();
Expand All @@ -259,7 +258,7 @@ export class Page extends LitElement {
}

} finally {
await closeProgressPopup();
closeProgressPopup && await closeProgressPopup();
}

return conversionOutput;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export class GuidedPreform extends Page {
subtitle: "Answer the following questions to simplify your workflow through the GUIDE",
};

#setWorkflow = () => (this.info.globalState.project.workflow = merge(this.state, structuredClone(defaults)));
#setWorkflow = () => this.info.globalState.project.workflow = this.state; // NOTE: Defaults already populated

beforeSave = async () => {
await this.form.validate();
Expand Down
2 changes: 0 additions & 2 deletions src/pyflask/manageNeuroconv/manage_neuroconv.py
Original file line number Diff line number Diff line change
Expand Up @@ -975,8 +975,6 @@ def update_backend_configuration(info: dict) -> dict:
backend = info_from_frontend.get("backend", "hdf5")
backend_configuration_from_frontend = info_from_frontend.get("results", {}).get(backend, {})

if not backend_configuration_from_frontend:
return None # Do not provide backend configuration if no customization is present

converter, metadata, __ = get_conversion_info(info)

Expand Down

0 comments on commit df7fde0

Please sign in to comment.