Move electron import to a preload script

NeurodataWithoutBorders · Oct 5, 2023 · 7eb406c · 7eb406c
1 parent e1fc902
commit 7eb406c
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 26 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,15 +2,11 @@
   "name": "nwb-guide",
   "productName": "NWB GUIDE",
   "version": "0.0.10",
-  "private": true,
   "description": "",
   "main": "./build/main/main.js",
   "engine": {
     "node": ">=18"
   },
-  "workspaces": [
-    "src/renderer"
-  ],
   "scripts": {
     "start": "electron-vite dev --outDir build",
     "postinstall": "electron-builder install-app-deps",

diff --git a/src/main/main.ts b/src/main/main.ts
@@ -19,6 +19,7 @@ import './application-menu.js';
 
 import icon from '../renderer/assets/img/logo-guide-draft.png?asset'
 import splashHTML from './splash-screen.html?asset'
+import preloadUrl from './../preload/preload.js?asset'
 
 // autoUpdater.channel = "latest";
 
@@ -242,7 +243,7 @@ function initialize() {
         enableRemoteModule: true,
         contextIsolation: false,
         sandbox: false,
-        // preload: path.join(__dirname, "preload.js"),
+        preload: path.join(preloadUrl),
       },
     };
 

diff --git a/src/preload/preload.js b/src/preload/preload.js
@@ -0,0 +1,13 @@
+
+const electron = require('electron')
+
+// Expose ipcRenderer
+if (process.contextIsolated) {
+    try {
+      electron.contextBridge.exposeInMainWorld('electron', electron)
+    } catch (error) {
+      console.error(error)
+    }
+  } else {
+    globalThis.electron = electron
+  }
diff --git a/src/preload/preload.ts b/src/preload/preload.ts
diff --git a/src/renderer/package.json b/src/renderer/package.json
diff --git a/src/renderer/src/electron/check.js b/src/renderer/src/electron/check.js
@@ -1,4 +1,3 @@
 var userAgent = navigator.userAgent.toLowerCase();
 export const isElectron = userAgent.indexOf(" electron/") > -1;
-
 export default isElectron;
diff --git a/src/renderer/src/electron/index.js b/src/renderer/src/electron/index.js
@@ -4,7 +4,7 @@ import isElectron from "./check.js";
 export { isElectron };
 
 export let port = 4242;
-export let electron = {};
+export const electron = globalThis.electron ?? {}; // ipcRenderer, remote, shell, etc.
 export let fs = null;
 export let os = null;
 export let remote = {};
@@ -15,13 +15,9 @@ export let crypto = null;
 
 if (isElectron) {
     try {
-        // Import Electron API
-        electron = require("electron"); // ipcRenderer, remote, shell, etc.
         fs = require("fs-extra"); // File System
         os = require("os");
-
         crypto = require("crypto");
-
         remote = require("@electron/remote");
         app = remote.app;
 

diff --git a/src/renderer/src/index.ts b/src/renderer/src/index.ts
@@ -25,7 +25,7 @@ const appVersion = app?.getVersion();
 
 const statusBar = new StatusBar({
   items: [
-    { label: unsafeSVG(webAssetSVG), value: appVersion ?? 'Web' },
+    { label: unsafeSVG(webAssetSVG), value: isElectron ? appVersion ?? 'ERROR' : 'Web' },
     { label: unsafeSVG(wifiSVG) },
     { label: unsafeSVG(serverSVG) }
   ]