Clear name error faster and when the user changes the field

NeurodataWithoutBorders · Apr 16, 2024 · 4c30444 · 4c30444
1 parent 2a40b38
commit 4c30444
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js b/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js
@@ -43,7 +43,7 @@ export class GuidedNewDatasetPage extends Page {
             const name = this.state.name;
             if (!name) {
                 if (this.#nameNotification) this.dismiss(this.#nameNotification); // Dismiss previous custom notification
-                this.#nameNotification = this.notify("Please enter a project name.", "error");
+                this.#nameNotification = this.notify("Please enter a project name.", "error", 3000);
                 return;
             }
 
@@ -97,7 +97,12 @@ export class GuidedNewDatasetPage extends Page {
             onOverride: (name) => {
                 this.notify(`<b>${header(name)}</b> has been overridden with a global value.`, "warning", 3000);
             },
-            validateOnChange,
+            validateOnChange: async (...args) => {
+                const results = await validateOnChange.call(this.form, ...args)
+                if (!results && args[0] === "name") this.#nameNotification && this.dismiss(this.#nameNotification);
+                return results
+
+            },
             onUpdate: () => (this.unsavedUpdates = true),
             onThrow: function (message) {
                 if (skipError(message)) return;