Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement to intro tutorial #633

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 21, 2024

Motivation

  • Remove duplicate code
  • Use consistent variable naming

How to test the behavior?

N/A

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Remove duplicate code
Use consistent variable naming
Comment on lines -154 to -158
% create processing module
behavior_mod = types.core.ProcessingModule('description', 'contains behavioral data');

% add the Position object (that holds the SpatialSeries object)
behavior_mod.nwbdatainterface.set('Position', Position);
Copy link
Collaborator Author

@ehennestad ehennestad Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code segment occurred twice. Removed here because the explanation for processing modules is introduced in the next section

Copy link
Collaborator Author

@ehennestad ehennestad Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed:
behavior_mod -> behavior_module
Position -> position

@bendichter bendichter merged commit f82e559 into master Nov 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants