Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

571 Add "from MATLAB Table" example to Dynamic Tables tutorial #604

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Oct 31, 2024

Fix #571

This PR adds a section on conversion from MATLAB table to dynamic table in the "Dynamic Tables" tutorial.

The other two points mentioned in the issue were already implemented

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad ehennestad requested a review from bendichter October 31, 2024 19:22
@ehennestad ehennestad changed the title 571 special table tutorial 571 Add "from MATLAB Table" example to Dynamic Tables tutorial Oct 31, 2024
@ehennestad ehennestad marked this pull request as draft October 31, 2024 21:45
@ehennestad ehennestad removed the request for review from bendichter October 31, 2024 21:45
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (bc4b87d) to head (e2b2648).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files         106      106           
  Lines        4686     4689    +3     
=======================================
+ Hits         4247     4250    +3     
  Misses        439      439           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad marked this pull request as ready for review November 1, 2024 10:56
@bendichter bendichter merged commit 70fcace into master Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Special tutorial page on Tables
2 participants