Allow LindiH5pyFile.from_hdf5_file to accept remote URL for local file #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to download a remote HDF5 file and create a lindi file with references to the remote location using the downloaded local HDF5 file. I think creating such a lindi file using a remote HDF5 file would take longer than downloading the file and creating such a lindi file using the downloaded local HDF5 file, but I am not sure.
LindiH5ZarrStore.from_file
lets you create a store using a local file with references to the remote location:lindi/lindi/LindiH5ZarrStore/LindiH5ZarrStore.py
Line 69 in 1fc62ef
LindiH5pyFile.from_hdf5_file
callsLindiH5ZarrStore.from_file
but does not let the user set the remote location to a location different from the file location:lindi/lindi/LindiH5pyFile/LindiH5pyFile.py
Line 61 in 1fc62ef
This PR exposes the
url
keyword argument inLindiH5ZarrStore.from_file
toLindiH5pyFile.from_hdf5_file
to allow those two locations to be different. The docstring is copied fromLindiH5ZarrStore.from_file
and modified.@magland please confirm that the last sentence of the docstring for
url
is still valid.