Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode nan, inf, -inf attributes as strings #14

Merged
merged 2 commits into from
Mar 15, 2024
Merged

encode nan, inf, -inf attributes as strings #14

merged 2 commits into from
Mar 15, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Mar 15, 2024

Implements proposal in #11

@rly you can see I am using your FloatJSONEncoder for every .zattrs, .zgroup, .zarray file

(btw, I accidentally included the README commit in this PR)

@magland magland requested a review from rly March 15, 2024 20:58
@rly
Copy link
Contributor

rly commented Mar 15, 2024

Looks good!

@magland magland merged commit 22d2bdb into main Mar 15, 2024
4 checks passed
@magland magland deleted the nan branch March 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants