-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpikeEventSeries data type #92
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fbd4d4a
add spike event series
stephprince 13515ad
add annotation series
stephprince 5ca3546
add data type creation functions
stephprince f65ffc2
add data types to cmake lists
stephprince d55c0b4
add checks whether object exists
stephprince 04d5d3a
skip adding electrode if it already exists
stephprince a1108ee
add electrodeTable and acquisitonPath to NWBFile
stephprince d41bb7c
update new data type inputs
stephprince 5fcfa63
fix tests
stephprince a8cb93f
fix object exists logic
stephprince 5468106
fix formatting
stephprince 11ece6c
remove annotationseries for separate pr
stephprince 915ba30
add writeSpikeEventSeries related functions
stephprince 5bf4d59
isolate electrode table related functions
stephprince 34c9aeb
update spikeEventSeries
stephprince 91b7aa5
update spikeevent inputs
stephprince e9c23cb
setup eventseries for different dims
stephprince 56f482c
update spike event tests - wip
stephprince 01313a9
fix tests
stephprince 052453b
remove annotation series
stephprince 90055c3
remove python script
stephprince c060e13
update spikeeventseries for diff dims
stephprince ab6a995
fix formatting
stephprince a6d86f9
remove old conditional
stephprince ddde29a
Apply suggestions from code review
stephprince 905547b
add check for device or electrode group existing
stephprince 2687aec
separate group and source name
stephprince f68a490
test 2d and 3d event series
stephprince 42788a0
test multiple ecephys dset creation
stephprince 3d32106
remove nSamples as input
stephprince cd2d098
fix formatting
stephprince 5d59c0b
update dset creation to take recordingNames as input
stephprince 378a8e4
fix formatting
stephprince 50004b7
update test to fix validation
stephprince File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now this seems fine. I assume this is part of #93 to address the groupName?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By address the
groupName
do you mean allowing different options forDevice
andElectrodeGroup
?From what I had in my notes we also discussed having a single
groupName
for achannelVector
. That would be part of #37There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.