integration related updates #89

stephprince · 2024-09-06T19:33:33Z

These are some minor updates related to the OpenEphys plugin integration here.

add data_collection and description as user provided inputs
fix conversion of data from float to int (also some small changes to related tests)
fix electrical series channel_conversion and electrodes attribute data write

src/Utils.hpp

src/nwb/NWBFile.hpp

oruebel

Just some minor questions/comments. Otherwise this looks good.

stephprince added 4 commits September 6, 2024 12:11

update float to int transform

e21c02a

update electrical series dataset write

08c44c1

update tests

cb7552d

update description and data collection inputs

6a913bb

stephprince marked this pull request as ready for review September 6, 2024 19:41

stephprince requested a review from oruebel September 6, 2024 19:41

oruebel reviewed Sep 6, 2024

View reviewed changes

src/Utils.hpp Show resolved Hide resolved

oruebel reviewed Sep 6, 2024

View reviewed changes

src/Utils.hpp Show resolved Hide resolved

oruebel reviewed Sep 6, 2024

View reviewed changes

src/nwb/NWBFile.hpp Outdated Show resolved Hide resolved

oruebel reviewed Sep 6, 2024

View reviewed changes

stephprince added 3 commits September 6, 2024 16:54

do not save description and dataCollection on nwbfile

cb6257e

add notes to data transform utils

8a6b776

Merge branch 'main' into plugin-updates

5fd403c

stephprince requested a review from oruebel September 7, 2024 00:20

oruebel approved these changes Sep 7, 2024

View reviewed changes

stephprince merged commit a10b62e into main Sep 9, 2024
8 checks passed

stephprince deleted the plugin-updates branch September 9, 2024 05:07

Provide feedback