-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDF5IO tests for add_read PR #118
Open
oruebel
wants to merge
16
commits into
add_read
Choose a base branch
from
add_read_hdf5io_tests
base: add_read
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+850
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets #85 to complete open ToDo items to add unit tests.
Add unit tests for public
HDF5IO
-specific functions (i.e., not inherited fromBaseIO
)HDF5IO::getH5ObjectType
HDF5IO::getNativeType
HDF5IO::getH5Type
Add unit tests for new public
HDF5IO
functions (which are core functions new inBaseIO
). While some of these are partially covered by theDEFINE_FIELDS
read tests, it will be useful to more fully test these separatelyHDF5IO::findTypes
(implemented inBaseIO::findTypes
)HDF5IO::readDataset
(incl. with start, count, stride, and block parameters set). This is to test that reading subsets of larger arrays works as expected.HDF5IO::open(FileMode mode)
test that file modes are being set correctlyHDF5IO::readAttribute
HDF5IO::getStorageObjectType
HDF5IO::getGroupObjects
HDF5IO::attributeExists
HDF5IO::objectExists