Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HDF5IO tests for add_read PR #118

Open
wants to merge 16 commits into
base: add_read
Choose a base branch
from
Open

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Dec 26, 2024

This PR targets #85 to complete open ToDo items to add unit tests.

Add unit tests for public HDF5IO-specific functions (i.e., not inherited from BaseIO)

  • HDF5IO::getH5ObjectType
  • HDF5IO::getNativeType
  • HDF5IO::getH5Type

Add unit tests for new publicHDF5IO functions (which are core functions new inBaseIO). While some of these are partially covered by the DEFINE_FIELDS read tests, it will be useful to more fully test these separately

  • HDF5IO::findTypes (implemented inBaseIO::findTypes)
  • HDF5IO::readDataset (incl. with start, count, stride, and block parameters set). This is to test that reading subsets of larger arrays works as expected.
  • HDF5IO::open(FileMode mode) test that file modes are being set correctly
  • HDF5IO::readAttribute
  • HDF5IO::getStorageObjectType
  • HDF5IO::getGroupObjects
  • HDF5IO::attributeExists
  • HDF5IO::objectExists

@oruebel oruebel marked this pull request as draft December 26, 2024 00:25
@oruebel oruebel mentioned this pull request Dec 26, 2024
68 tasks
@oruebel oruebel marked this pull request as ready for review December 26, 2024 01:35
@oruebel oruebel requested a review from stephprince December 26, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant