Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member variable names to avoid shadowing #102

Merged
merged 29 commits into from
Sep 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2071445
Update Channel.hpp/cpp to avoid shadowing
oruebel Sep 19, 2024
43313cb
Fix formatting
oruebel Sep 19, 2024
5c69181
Update names in RecordingContainers
oruebel Sep 19, 2024
0685e57
Update members in NWBFile
oruebel Sep 19, 2024
f4583b3
Update members in Container
oruebel Sep 19, 2024
615b03c
Fix formatting
oruebel Sep 19, 2024
476d7c7
Update members in Data.hpp
oruebel Sep 19, 2024
131a914
Update member in HDF5RecordingData
oruebel Sep 19, 2024
e10535f
Update members in BaseIO and HDF5IO
oruebel Sep 19, 2024
42a43a8
Update members in VectorData
oruebel Sep 19, 2024
fcea059
Fix formatting
oruebel Sep 19, 2024
341739e
Fix ubuntu build error
oruebel Sep 19, 2024
669fa95
Fix Doxygen built errors
oruebel Sep 19, 2024
ad7aea4
Replace this->m_ with just m_
oruebel Sep 20, 2024
be49619
Update src/nwb/ecephys/SpikeEventSeries.hpp
oruebel Sep 20, 2024
430600a
Remove setters from channel
stephprince Sep 20, 2024
3a685f6
Make simple getters in BaseIO in the header and remove redundant over…
oruebel Sep 20, 2024
6d3c520
Merge branch 'resolve_shadowing' of https://github.com/lbl-cbg/aq-nwb…
oruebel Sep 20, 2024
57c8520
Fix formatting
oruebel Sep 20, 2024
b7a8792
Make simple getter for HDF5RecordingData inline
oruebel Sep 20, 2024
f1122d0
Make simple getter for RecordingContainers inline
oruebel Sep 20, 2024
940bf06
replace this->m_ with just m_
stephprince Sep 20, 2024
d73d7a2
Move simple setters for DynamicTable and remove redundant definitions…
oruebel Sep 20, 2024
4ba163f
Merge branch 'resolve_shadowing' of https://github.com/lbl-cbg/aq-nwb…
oruebel Sep 20, 2024
f2816c2
fix formatting
stephprince Sep 20, 2024
7bc8d3c
Fix formatting
oruebel Sep 20, 2024
6bca260
Merge branch 'resolve_shadowing' of https://github.com/lbl-cbg/aq-nwb…
oruebel Sep 20, 2024
45a1238
Move VectorData getters
oruebel Sep 20, 2024
f00b03c
Fix hidden ElectrodeTable.colNames member and bad init
oruebel Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make simple getter for HDF5RecordingData inline
oruebel committed Sep 20, 2024
commit b7a8792195d21539f2b4b4cae35ff84a9e33349b
5 changes: 0 additions & 5 deletions src/hdf5/HDF5IO.cpp
Original file line number Diff line number Diff line change
@@ -727,8 +727,3 @@ Status HDF5RecordingData::writeDataBlock(
}
return Status::Success;
}

const H5::DataSet* HDF5RecordingData::getDataSet()
{
return this->m_dataset.get();
};
2 changes: 1 addition & 1 deletion src/hdf5/HDF5IO.hpp
Original file line number Diff line number Diff line change
@@ -319,7 +319,7 @@ class HDF5RecordingData : public BaseRecordingData
* @brief Gets a const pointer to the HDF5 dataset.
* @return A const pointer to the HDF5 dataset.
*/
const H5::DataSet* getDataSet();
inline const H5::DataSet* getDataSet() const { return this->m_dataset.get(); }

private:
/**