Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectricalSeries.channel_conversion not schema compliant #109

Closed
oruebel opened this issue Sep 21, 2024 · 0 comments · Fixed by #110
Closed

ElectricalSeries.channel_conversion not schema compliant #109

oruebel opened this issue Sep 21, 2024 · 0 comments · Fixed by #110

Comments

@oruebel
Copy link
Contributor

oruebel commented Sep 21, 2024

ElectricalSeries.channel_conversion is:

  • missing the attribute axis, which should be int32 with a fixed value of 1
  • has extra attributes for object_id, description and namespace . Only objects with a specified neurodata_type should get these extra attributes.

I believe the following code should be removed:

m_io->createCommonNWBAttributes(getPath() + "/channel_conversion",
"hdmf-common",
"",
"Bit volts values for all channels");

and the new int attribute axis should be added instead. This error is currently missing in the validation with nwbinspector due to #108

https://nwb-schema.readthedocs.io/en/latest/format.html#sec-electricalseries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant