Skip to content

Commit

Permalink
Fix #109 Add missing axis attribute for channel_conversion and remove…
Browse files Browse the repository at this point in the history
… extra attributes
  • Loading branch information
oruebel committed Sep 21, 2024
1 parent 9d7f408 commit 435866c
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/nwb/ecephys/ElectricalSeries.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,13 @@ void ElectricalSeries::initialize(const IO::BaseDataType& dataType,
std::vector<SizeType>(1, channelVector.size()),
IO::BaseDataType::F32,
&channelConversions[0]);

m_io->createCommonNWBAttributes(
this->getPath() + "/channel_conversion",
"hdmf-common", // TODO shouldn't this be core?
"",
"Bit volts values for all channels");
// add axis attribute for channel conversion
const signed int axis_value = 1;
m_io->createAttribute(IO::BaseDataType::I32,
&axis_value,
this->getPath() + "/channel_conversion",
"axis",
1);

// make electrodes dataset
electrodesDataset = std::unique_ptr<IO::BaseRecordingData>(
Expand Down

0 comments on commit 435866c

Please sign in to comment.