-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make BaseTestRawIO
setup per class and not per test
#1553
Make BaseTestRawIO
setup per class and not per test
#1553
Conversation
Looks like maxwell testing relies directly on setUp? Do you want to dig into or you want me to?
|
Fixed. |
Co-authored-by: Zach McKenzie <[email protected]>
@nikhilchandra, want to test to see if this fixes your issues using the testing locally? |
I want to add that I think this is a good improvement on its own for tests with multiple cases so the download is not attempted twice anyway. |
I agree. I was hoping for a magic speed-up. But it looks like we go from 7-8 min to 6-7 min. So a slight (although not statistically tested) improvement in test speed. Sam can confirm he is okay with it tomorrow either way and we can merge then. |
1 minute is great : ) |
@zm711 will give it a shot in a bit, thanks! |
Genial |
Related to the discussion in #1550