Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BaseTestRawIO setup per class and not per test #1553

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

h-mayorquin
Copy link
Contributor

Related to the discussion in #1550

@zm711
Copy link
Contributor

zm711 commented Sep 12, 2024

Looks like maxwell testing relies directly on setUp? Do you want to dig into or you want me to?

FAILED neo/test/rawiotest/test_maxwellrawio.py::TestMaxwellRawIO::test_read_all - AttributeError: type object 'BaseTestRawIO' has no attribute 'setUp'

@h-mayorquin
Copy link
Contributor Author

Fixed.

@h-mayorquin h-mayorquin marked this pull request as ready for review September 12, 2024 16:15
@zm711
Copy link
Contributor

zm711 commented Sep 12, 2024

@nikhilchandra, want to test to see if this fixes your issues using the testing locally?

@h-mayorquin
Copy link
Contributor Author

I want to add that I think this is a good improvement on its own for tests with multiple cases so the download is not attempted twice anyway.

@zm711
Copy link
Contributor

zm711 commented Sep 12, 2024

I want to add that I think this is a good improvement on its own for tests with multiple cases so the download is not attempted twice anyway.

I agree. I was hoping for a magic speed-up. But it looks like we go from 7-8 min to 6-7 min. So a slight (although not statistically tested) improvement in test speed.

Sam can confirm he is okay with it tomorrow either way and we can merge then.

@h-mayorquin
Copy link
Contributor Author

1 minute is great : )

@nikhilchandra
Copy link

@zm711 will give it a shot in a bit, thanks!

@samuelgarcia
Copy link
Contributor

Genial

@zm711 zm711 merged commit e8ea631 into NeuralEnsemble:master Sep 13, 2024
3 checks passed
@h-mayorquin h-mayorquin deleted the make_base_test_setup branch September 13, 2024 13:47
@zm711 zm711 added this to the 0.14.0 milestone Sep 23, 2024
@zm711 zm711 modified the milestones: 0.14.0, 0.13.4 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants