Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix electrode selection in Axona raw recording #1520
base: master
Are you sure you want to change the base?
Fix electrode selection in Axona raw recording #1520
Changes from 4 commits
15c5d9f
547c8ae
0d4b92e
e6685be
03affe4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the benefit of concat? I need to doublecheck what is
chan
is it a list of all channels from a tetrode. If that is the case I would call itchannels
orchans
instead so we know it's plural.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
chan
is a list of all channels from a tetrode, so I agree to call itchannels
orchans
.Since I was using this function only for the
_get_analogsignal_chunk
function and it needed the list of active channels as an array I returned directlyactive_channels
as an array. But we can also do it in_get_analogsignal_chunk
and keep this function consistent withget_active_tetrodes
and return directlyactive_channels