Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read gain scaling from .rec header. #1448

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

gkBCCN
Copy link
Contributor

@gkBCCN gkBCCN commented Mar 28, 2024

Updates spikegadgetsrawio.py:_parse_header() to read the channel (ntrode) gain scaling from the header file elements.

Updates spikegadgetsrawio.py:_parse_header() to read
the channel (ntrode) gain scaling from the header file elements.
@alejoe91 alejoe91 changed the title Fix issue #1441: Read gain scaling from .rec header. Read gain scaling from .rec header. Mar 28, 2024
@alejoe91
Copy link
Contributor

Fixes #1441

@gkBCCN if you write "fixes" + issue number it will close it automatically as the PR is merged ;) Better this way than in the PR title

Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think about how to update the notes for this section really quick to try to make this as clear as possible for the end-users.

neo/rawio/spikegadgetsrawio.py Show resolved Hide resolved
neo/rawio/spikegadgetsrawio.py Outdated Show resolved Hide resolved
@alejoe91 alejoe91 added this to the 0.13.1 milestone Apr 5, 2024
...also adds clarification in docstring.
@alejoe91
Copy link
Contributor

alejoe91 commented Apr 9, 2024

@zm711 @gkBCCN looks good to me!

Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@alejoe91 alejoe91 merged commit e9b57b0 into NeuralEnsemble:master Apr 9, 2024
2 checks passed
@gkBCCN
Copy link
Contributor Author

gkBCCN commented Apr 9, 2024

@zm711 @alejoe91 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants