-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeuralynxIO: Factor out header handling. #1404
NeuralynxIO: Factor out header handling. #1404
Conversation
This is failing because the test data are not in ephy_testing_data yet. For that I am waiting on clarification of how to check the files in. See the google groups thread "New workflow with datalad?" |
Regarding your google group message about incorporating some of your local code. Could you describe a bit more what it is doing? I think making things more robust/flexible would be great, but it also needs to fit within the Neo framework. So you can either open an issue to discuss what you're proposing if you have a hunch that your code might be bigger changes to neuralynx. Or you could open a draft PR and see what happens in the test suite with the rest of the code if you incorporate some of your code. |
I added pull request #116 for ephy_testing_data for the dataset which will allow this to pass checks. That pull request on the dataset should be ready to go. |
@PeterNSteinmetz , @samuelgarcia is going to look over everything very soon for your recent PRs so you'll have feedback on everything asap. |
Hi @PeterNSteinmetz. |
This factors parsing the NlxHeader into parts and provides an option to construct without testing for time and date.