Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlexonRawIO style #1343

Merged
merged 4 commits into from
Feb 2, 2024
Merged

PlexonRawIO style #1343

merged 4 commits into from
Feb 2, 2024

Conversation

bendichter
Copy link
Contributor

  • optimize imports
  • add tqdm for longer steps
  • add tqdm as a requirement for plexon
  • a bit of black-like formatting

@bendichter
* optimize imports
ded9a66 
* add tqdm to longer steps
* a bit of black-like formatting
* add tqdm as a requirement for plexon
@pep8speaks
Copy link

pep8speaks commented Nov 1, 2023 •
edited
Loading

Hello @bendichter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-01 15:10:41 UTC

@apdavison apdavison added this to the 0.13.0 milestone Jan 26, 2024
@samuelgarcia
Copy link
Contributor

Hi Ben.
Thank for the patch.
Sorry for the long delay on this.
I made a small change to make the tqdm optional on plexon.

This is OK for merging.

@apdavison apdavison merged commit ca7e142 into NeuralEnsemble:master Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgarcia samuelgarcia samuelgarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bendichter @pep8speaks @samuelgarcia @apdavison