Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_asciisignalio to work on Windows #1341

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented Oct 20, 2023

Since Windows use a different newline in order for the csv to work the newline argument must be specified. Adding this doesn't affect Linux testing, but it makes my life better when running local tests on Windows.

@pep8speaks
Copy link

pep8speaks commented Oct 20, 2023

Hello @zm711! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-20 21:27:44 UTC

@apdavison
Copy link
Member

For future reference, the reason for this is given in the Python docs here: https://docs.python.org/3/library/csv.html#id3

@apdavison apdavison added this to the 0.13.0 milestone Oct 23, 2023
@apdavison apdavison merged commit a36df30 into NeuralEnsemble:master Oct 23, 2023
@zm711 zm711 deleted the fix-ascii-test-windows branch October 23, 2023 11:10
@zm711
Copy link
Contributor Author

zm711 commented Oct 23, 2023

Thanks @apdavison, next time I'll include the link documentation in the PR message itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants