adds findDOHEndpoint() for given zone to JS API #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptix
approved these changes
Jul 31, 2024
| } | ||
|
|
||
| const div = document.getElementById("domain-doh-endpoint") | ||
| if (div.children.length > 0) { |
There was a problem hiding this comment.
not sure if it is possible to have more then one but instead of removing the first you can also just div.innerHTML = "", i think.
| @@ -64,6 +64,7 @@ func FindDOHEndpoint(name string) (*url.URL, error) { | |||
| return nil, fmt.Errorf("findDOHEndpoint: no answer section for %s", lookup) | |||
| } | |||
|
|
|||
| // TODO deal with more than one SVCB "_dns." + name in RRSet | |||
There was a problem hiding this comment.
good call!
we should start making a list of things we need static test vectors for to drop our need for network i/o during tests and this would definitely be one of them.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial findDOHEndpoint() to WASM JS API