-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_subscribeTransactionStatus websocket method #2210
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 75.60% 75.14% -0.47%
==========================================
Files 104 104
Lines 11102 11430 +328
==========================================
+ Hits 8394 8589 +195
- Misses 2074 2194 +120
- Partials 634 647 +13 ☔ View full report in Codecov by Sentry. |
c5eb695
to
abfec15
Compare
Co-authored-by: rian <[email protected]> Co-authored-by: LordGhostX <[email protected]>
dae4ff2
to
bffd2bf
Compare
}, | ||
{ | ||
Name: "starknet_subscribeTransactionStatus", | ||
Params: []jsonrpc.Parameter{{Name: "transaction_hash"}, {Name: "block"}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block
should be optional as per the specs
return err | ||
} | ||
|
||
func (h *Handler) SubscribeTxnStatus(ctx context.Context, txHash felt.Felt, _ *BlockID) (*SubscriptionID, *jsonrpc.Error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the specs, we also need to support historical blocks. Or is it not possible?
Fixes #2209
This is based on #2211